Fix compatibility clause for attachments #5461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a mixed cluster, with nodes before and after #5373 where `pread_iolist` and `append_bin` were removed, attachment operations may throw function_clause errors on the new couch_file gen_servers. That's because attachment streams may be opened on one node, but operations on them maybe called from another node. As such, we have to handle the old gen_server messages until the next version.
nickva
force-pushed
the
handle-attachment-writes-during-upgrades
branch
from
b5134f6 to
c134edb
Compare
jaydoane
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a mixed cluster, with nodes before and after #5373 where
pread_iolistandappend_binwere removed, attachment operations may throw function_clause errors on the new couch_file gen_servers. That's because attachment streams may be opened on one node, but operations on them maybe called from another node. As such, we have to handle the old gen_server messages until the next version.