Fix props caching in mem3 #5690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in #5672 we incorrectly stored some of the properties. The properties for the dbs db were stored correclty as `ets:insert(mem3_opts, {db, opts})` while for the other dbs they were stored as `ets:insert(mem3_opts, opts)`. All the requests would still work fine but the cache wouldn't be used as the values would be loaded from the db doc every time. Fix the bug and also adjust the name of `Opts` variable, we're not storing props but opts so rename it to reflect reality and avoid confusion. While at it, update the test suite to use the `?TDEF_FE` macro and get rid of all the `_test(begin ... end)` boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in #5672 we incorrectly stored some of the properties.
The properties for the dbs db were stored correctly as
ets:insert(mem3_opts, {db, opts})while for the other dbs they were stored asets:insert(mem3_opts, opts). All the requests would still work fine but the cache wouldn't be used as the values would be loaded from the db doc every time.Fix the bug and also adjust the name of
Optsvariable, we're not storing props but opts so rename it to reflect reality and avoid confusion.While at it, update the test suite to use the
?TDEF_FEmacro and get rid of all the_test(begin ... end)boilerplate.