feat: concat eunit test logs and remove test tmp dirs in Makefile #5830
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows debugging of test runs in a unified log. It also retains individual test run state dirs if `make eunit` fails. The next successful run will clean it up
big-r81
approved these changes
Dec 20, 2025
nickva
reviewed
Dec 22, 2025
| eunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(CURDIR)/bin/couchjs $(CURDIR)/share/server/main.js | ||
| eunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1 | ||
| eunit: ${SUBDIRS} | ||
| @cat tmp/couchdb-tests/*/log/couch.log > tmp/couch.log |
Contributor
There was a problem hiding this comment.
In case of an eunit failure we won't run the commands here so we won't get all the logs. We only get them on success. But we may want the opposite case - in case of success ignore them, but in case of failure inspect them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows debugging of test runs in a unified log.
It also retains individual test run state dirs if
make eunitfails. The next successful run will clean it up