Properly kill OS daemons during test#587
Merged
Merged
Conversation
eiri
reviewed
Jun 8, 2017
| catch | ||
| {timeout, os_daemon_stop} -> | ||
| Msg = "WARNING: OS daemons test stop ~p msec timeout exceeded", | ||
| io:format(standard_error, Msg, [?TIMEOUT]), |
Member
There was a problem hiding this comment.
You forgot ~n at the end, but why io:format/3 and not ?debugFmt/2?
Contributor
Author
There was a problem hiding this comment.
Good point will add the ~n.
Thought of ?debugMsg but remembered @janl's observation that he didn't see ?debugMsg lines in the logs.
?debugMsg docs say it outputs to console. Wonder if when running in Travis console and stderr end up being two different things...
Member
There was a problem hiding this comment.
I suspect it has something to do with how rebar sets DEBUG - NODEBUG macros, but not sure, maybe it is how travis treats stdout and stderr.
Even if it clean up fails use `kill` to avoid failing the next set of tests. Issue: apache#571
nickva
force-pushed
the
os-daemons-timeout
branch
from
9911f55 to
70ed871
Compare
eiri
reviewed
Jun 8, 2017
Member
eiri
left a comment
eiri
left a comment
There was a problem hiding this comment.
[done in 7.409 s]
=======================================================
All 1154 tests passed.
+1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if it clean up fails use
killto avoid failing the next set of tests.Issue: #571