feat: Implement inverted range check for _all_docs #5874
Conversation
|
Please complete the PR template correctly, and specifically to confirm that this is your work and not the output of an LLM tool. The tests should be added to existing test suites, the one you have written (or generated) contains a lot of duplication from elsewhere and will not be accepted. |
- Add tests to chttpd_view_test.erl instead of separate file - Remove duplicate test file - Address maintainer feedback
Address maintainer feedback by integrating tests into existing suite
|
I have addressed both of your concerns by confirming in the PR template that this is my own work and moving the tests into the existing |
2 participants
This PR implements a validation check for _all_docs requests to ensure that start_key is not greater than end_key (or vice versa when descending=true).
Previously, _all_docs queries with inverted ranges would return empty results without a clear indication of the error. This change aligns the behavior of _all_docs with _view, which already rejects inverted ranges with a 400 Bad Request.
Users providing an invalid range will now receive the following error:
{"error":"query_parse_error","reason":"No rows can match your key range, reverse your start_key and end_key or set descending=true"}
Testing recommendations
I have added two new test cases to the existing
src/chttpd/test/eunit/chttpd_view_test.erl
suite:
t_all_docs_with_inverted_range - verifies 400 error for inverted ranges
t_all_docs_with_inverted_range_descending - verifies correct behavior with descending=true
Manual testing can be done by querying _all_docs with an inverted range and verifying the 400 response.
Related Issues or Pull Requests
Fixes #5866
Checklist
This is my own work, I did not use AI, LLM's or similar technology
Code is written and works correctly
Changes are covered by tests
Any new configurable parameters are documented in
rel/overlay/etc/default.ini
Documentation changes were made in the src/docs folder
Documentation changes were backported (separated PR) to affected branches