Use errstr() instead of toSource() in nouveau js wrapper#5976
Merged
Conversation
big-r81
approved these changes
Apr 22, 2026
`toSource()` is a Spidermonkey special, use our `errstr()` warpper function which checks if `toSource()` is available, and if not, it runs `toString()` instead
big-r81
force-pushed
the
errstr-in-nouveau-instead-of-tosource
branch
from
2abd60f to
357edeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toSource()is a Spidermonkey special, use ourerrstr()warpper function which checks iftoSource()is available, and if not, it runstoString()insteadThis one line fix (minus the test) was originally submitted by a new contributor in #5951. When we requested a few changes they closed the pr without comments 🤷