Fix race in couchdb_views_tests#600
Merged
Merged
Conversation
There are a race condition in `restore_backup_db_file` function between couch_server eviction of an old db updater and a test quering view on restored db file. The query in test can get old record for the updater and then crash with `noproc` exception. This change makes `restore_backup_db_file` to wait until start of the new db updater.
Contributor
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
There are a race condition in
restore_backup_db_filefunction between couch_server eviction of an old db updater and a test quering view on restored db file. The query in test can get old record for the updater and then crash withnoprocexception.This change makes
restore_backup_db_fileto wait until start of the new db updater.Testing recommendations
The following should pass:
make eunit apps=couch suites=couchdb_views_tests tests=backup_restore_test_GitHub issue number
Fixes #565
Checklist