Fix bulk_get not_found response handling when revs=all#6004
Merged
Conversation
Since revs=all when doc is not found we return `{ok, []}` we didn't count that
response as a not_found response and success_possible would return false too
early. If a node was in mm mode and that was the last response we could end up
emitting that as an internal error instead of the proper "not found" result.
Member
|
This is compounded if you fetch multiple documents at once where one exists and another does not and when they are in different shard ranges. if you receive the messages for the non-existent document before the ones for the doc that does exist, this code will return an error tuple (for reason 'maintenance_mode') for all the attempted gets. |
rnewson
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since revs=all when doc is not found we return
{ok, []}we didn't count that response as a not_found response and success_possible would return false too early. If a node was in mm mode and that was the last response we could end up emitting that as an internal error instead of the proper "not found" result.