Skip to content

Fix for 1799#61

Merged
asfgit merged 1 commit intoapache:masterfrom
ocasta:1799-rewrite-session-cookie-fix
May 22, 2013
Merged

Fix for 1799#61
asfgit merged 1 commit intoapache:masterfrom
ocasta:1799-rewrite-session-cookie-fix

Conversation

@ocasta
Copy link

@ocasta ocasta commented May 22, 2013

Save the auth values along with the User context so that if the AuthSession cookie has passed the time left threshold a new Set-Cookie is returned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nitpick but this is a whitespace error.

@kocolosk
Copy link
Member

It took me a few minutes to figure out what's going on here. The issue is that when the rewriter sets a #user_ctx on the request it bypasses all of the auth handlers on the second time around. That's a good thing, but it means that #httpd.auth is undefined, which means that when we call couch_httpd_auth:cookie_auth_header/2 it won't add a new Set-Cookie.

The code looks good. Thanks for the contribution!

@asfgit asfgit merged commit 1122401 into apache:master May 22, 2013
kocolosk added a commit that referenced this pull request Jun 29, 2013
kocolosk added a commit that referenced this pull request Jun 29, 2013
cararemixed pushed a commit to cararemixed/couchdb that referenced this pull request Dec 9, 2014
Add Travis CI hook and build status
nickva pushed a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017
This closes apache#61

Signed-off-by: Eric Avdey <eiri@eiri.ca>
nickva pushed a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017
This closes apache#61

Signed-off-by: Eric Avdey <eiri@eiri.ca>
nickva added a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017
jaydoane pushed a commit that referenced this pull request Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants