Skip to content

Conversation

@willholley
Copy link
Member

Overview

Mango operator tests previously only ran against json indexes. This PR ensures they also run against a database with no indexes (i.e. verify "pure" selector behaviour) as well as against json indexes and text indexes (when available). The intention here is to catch any inconsistencies or change in results that might occur due to the index selected (clearly we don't want results to change because a user adds an index!).

Note that text indexes do not currently pass these tests, but are not exercised as part of the CouchDB test suite.

Testing recommendations

Ensure the test suite runs (CI should handle this).

GitHub issue number

Related Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

Tests consistent behaviour for handling null values
and range queries between different index types
(_all_docs, json indexes and text indexes).
Copy link
Member

@garrensmith garrensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@garrensmith garrensmith merged commit aa14e5d into apache:master Sep 11, 2017
wohali pushed a commit that referenced this pull request Oct 19, 2017
* add operator tests for text indexes

* add operator tests for _all_docs

* add tests for null and range handling

Tests consistent behaviour for handling null values
and range queries between different index types
(_all_docs, json indexes and text indexes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants