Skip to content

Ignore javascript test suites#889

Merged
tonysun83 merged 2 commits intomasterfrom
flexible-js-tests
Oct 25, 2017
Merged

Ignore javascript test suites#889
tonysun83 merged 2 commits intomasterfrom
flexible-js-tests

Conversation

@tonysun83
Copy link
Contributor

@tonysun83 tonysun83 commented Oct 14, 2017

Overview

This PR enhances allows developers to ignore javascript test suites with the new option
ignore_js_suites.

Example usage:

make javascript ignore_js_suites="all_docs basics"
make javascript suites="all_docs basics view_errors" ignore_js_suites=
"view_errors"

The second example is redundant but the functionality works.

Testing recommendations

Try variations of make javascript with suites= and ignore_js_suites=

Related Issues or Pull Requests

The issue is this PR

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali
Copy link
Member

wohali commented Oct 14, 2017

What is the use case here? I'm baffled.

@tonysun83
Copy link
Contributor Author

tonysun83 commented Oct 16, 2017

@wohali : One use case I imagined is where developers would like to use the javascript test suite to provide more test coverage while they develop new features. The feature could be breaking tests due to some integration issue (waiting on another developer's commit/feature). Knowing the issue, the developer wants to ignore the test and be at least confident that other tests are not failing due to other regression issues caused by his or her change.

@wohali
Copy link
Member

wohali commented Oct 16, 2017

You can run individual JS tests already. Do you see a need to be able to run "all but some" and not just "only run these few tests I actively care about?"

@tonysun83
Copy link
Contributor Author

I think it would be good to have the capability to run "all but some". I know for the eunit tests we have skip_deps, which is different in approach as it skips apps, but I wanted something with similar functionality. It provides a better feeling of robustness for any new feature development.

@nickva
Copy link
Contributor

nickva commented Oct 17, 2017

I like this. Seems symmetric with skip apps / deps

+1

@janl
Copy link
Member

janl commented Oct 19, 2017

agree this would be neat, but didn’t get it at first like @wohali. I too like the symmetry. Either way, whatever helps make running tests more comfortable :)

@janl
Copy link
Member

janl commented Oct 19, 2017

@tonysun83 wanna add a few lines of docs to https://github.com/apache/couchdb/blob/master/README-DEV.rst#testing +1 afterwards

Developers can now ignore javascript test suites with the new option
ignore_js_suites.

Example usage:

make javascript ignore_js_suites="all_docs basics"
make javascript suites="all_docs basics view_errors" ignore_js_suites=
"view_errors"

The second example is redundant but the functionality works.
@tonysun83 tonysun83 merged commit 629a3e0 into master Oct 25, 2017
@tonysun83 tonysun83 deleted the flexible-js-tests branch March 8, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants