Skip to content

Fix Mango text index tests#971

Merged
willholley merged 1 commit intoapache:masterfrom
willholley:text-index-test-fixes
Nov 14, 2017
Merged

Fix Mango text index tests#971
willholley merged 1 commit intoapache:masterfrom
willholley:text-index-test-fixes

Conversation

@willholley
Copy link
Copy Markdown
Member

Overview

The text index tests are not routinely run by the Couch CI
(due to an external dependency that isn't shipped with Couch).
This fixes a number of tests that were broken as a result of
recent feature changes.

Testing recommendations

Run the mango tests with text indexes enabled.

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 7, 2017

I'd like to hold back on a +1 here until someone can run CouchDB (not Cloudant) with Mango and clouseau/dreyfus enabled to validate that this works. Don't rely on the Travis CI results here to provide that for you.

Perhaps in the future we can look at adding clouseau/dreyfus to the CI run. Just because we can't ship them with CouchDB doesn't mean we can't test against them! :)

@tonysun83
Copy link
Copy Markdown
Contributor

+1.
I setup dreyfus/clouseau and cherry-picked this commit and ran the entire test bucket:

(venv)Tonys-MBP:test tonysun$ MANGO_TEXT_INDEXES=1 nosetests
...................................................S.S.S.S............S.S.S.S............S.S.S.S.............................................................S................................................................................................................
----------------------------------------------------------------------

The text index tests are not routinely run by the Couch CI
(due to an external dependency that isn't shipped with Couch).
This fixes a number of tests that were broken as a result of
recent feature changes.
@willholley willholley merged commit 563b904 into apache:master Nov 14, 2017
@willholley willholley deleted the text-index-test-fixes branch November 14, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants