Add license header to .travis.yml #14
Conversation
|
Yeah. Shouldn't RAT repo be checked with RAT ;) ? Eating your own dog food :D |
jochenw
left a comment
jochenw
left a comment
There was a problem hiding this comment.
Okay, thanks for this change.
You are right, of course, Unfortunately, it's a non-trivial task, to build a Maven plugin, and use it within its own build. If you have any solutions to work around that chicken, and egg, problem: We re ready to listen. |
|
Why not using CLI interface to check it ? Surely the .jar file is built at some point in time and you can just use 'java -jar SOURCES' |
|
This way you can additionally check if the CLI interface still works. |
|
If you think it might work, I might even try to dust off my maven shelf in the brain (been there done that) and contribute it ... |
|
I work on a PR now: mik-laj#2 |
|
Final PR: #15 |
|
Sorry for the misunderstanding - RAT checks itself during build: Certain files are excluded as they are not part of the released artefact: So we do not need a header in the Travis file. |
4 participants
Hello,
I noticed that the license header is missing in this file. I wonder if it's necessary, so I created PR to talk about it. What are your thoughts on this topic? Which files should have a header?
Best regards,
CC: @potiuk