RequestForComments/Feedback - RAT-273: Due to JDK changes test expectations had to be changed when building against newer JDKs

[ottlinger]

LineNumberReader behaves differently in newer JDKs, thus test expectations read more lines as a line ending is treated differently than in JDK8.

see details in https://issues.apache.org/jira/browse/RAT-273

• RFC/ wait for feedback
• adapt changelog after merge to get these changes into the release log
• fix Javadoc errors happening with JDK17
• fix error in RatCheckMojoTest

Caused by: java.lang.reflect.InaccessibleObjectException: 
Unable to make field private static volatile java.nio.charset.Charset java.nio.charset.Charset.defaultCharset accessible: 
module java.base does not "opens java.nio.charset" to unnamed module @2a098129

[ottlinger]

@jochenw can you help out with the problems in RatCheckMojoTest? I experimented with adding argLine arguments to maven-surefire/failsafe plugin but am unable to get it running locally with JDK18. Maybe you know a workaround. Thanks
patchForRatCheckMojoTest.txt

[jochenw]

@ottlinger Glad to help, if you let me know, how to reproduce the issue. For now, I'll assume that I only need to use Java 17.

[ottlinger]

@jochenw if you apply the attached patch to the branch you'll see the RatCheckMojoTest failures ..... with JDK17 and 18. Apart from that there seems to be a javadoc issue, but any help is greatly appreciated :
patchShowingErrorWithJDK18or17.txt
)

In the patch I tried to add argument parameters that should fix the error, but maybe you have a solution that is within the code itself.

[ottlinger]

Will create new tickets once the problems arise.