Skip to content

Conversation

@amarkevich
Copy link
Contributor

No description provided.

@coheigea
Copy link
Contributor

@amarkevich Have you checked that this part is still working properly? "roleName.substring(5)"

Role role = roleDAO.getRole(roleName.substring(5), Arrays.asList("all"));

@amarkevich
Copy link
Contributor Author

amarkevich commented Dec 2, 2019

@coheigea Behavior is the same:
added debug output at pointed line
System.out.println(roleName + " -> " + roleName.substring(5));
and build for example systests/idp found expected

ROLE_IDP_LOGIN -> IDP_LOGIN

but also some

CLAIM_LIST -> _LIST
IDP_READ -> EAD

@coheigea
Copy link
Contributor

@amarkevich Maybe we need to check to see if the role starts with "ROLE_"?

@andrei-ivanov
Copy link

The role prefix should be configurable in Spring Security, it could be missing entirely

Copy link
Contributor

@coheigea coheigea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the simpleWebapp demo + OIDC and it works fine. RS interface seems to work fine as well.

@coheigea coheigea merged commit 79796b0 into apache:master Jun 11, 2020
@amarkevich amarkevich deleted the spring-security-4 branch June 23, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants