-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CXF-8758]:Add wiremock-standalone test dependency to fix all tests u… #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@reta It seems we pull the com.github.tomakehurst:wiremock-standalone:2.27.2 test scope dependency and it works for all tests under rt/rs/microprofile-client and systests/jaxrs/JAXRSClientMetricsTest. Although this imports some javax servelt and jetty9 artifacts , but they are all for test purpose and doesn't pollute any microprofile client and system test client side dependencies. After the wiremock jakarta version is ready ,we can change back to use the com.github.tomakehurst:wiremock dependency to imports the jakarta servelt and jetty11 dependency. If you want me to include wiremock change for system/jaxrs, please let me know. |
This is useful trick, thanks @jimma ! Do you think we could wait a bit before merging this one (🤞 the we would have wiremock snapshots available)? For |
@reta I'd prefer to add this to upstream to show how many jakarta failures left we need to fix before we have a wiremock(with jetty11 update) snapshot available. Because update to wiremock snapshot could be one line change , and it's easy to change after it's available. WDYT ?
|
@jimma sure, no objections, could you please rebase / merge with main? thank you. |
…nder microprofile-client module
|
Done. Thanks @reta. |
…nder microprofile-client module