only load the lifecycle, bus and event once to make test faster#1563
Merged
reta merged 1 commit intoapache:mainfrom Dec 14, 2023
Merged
only load the lifecycle, bus and event once to make test faster#1563reta merged 1 commit intoapache:mainfrom
reta merged 1 commit intoapache:mainfrom
Conversation
Member
|
Thank you for contribution @TestBoost ! |
reta
approved these changes
Dec 14, 2023
reta
pushed a commit
that referenced
this pull request
Dec 14, 2023
(cherry picked from commit de62361)
reta
pushed a commit
that referenced
this pull request
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test class
ClassUnwrapperTesttries to load thelifecycle,busandeventbefore every test runs in this test class.For
event, the test classServletContextEventcreates it with a mocked class and it is only used when starting the application usinglifecycle.For
lifecycle, it is only used to start an application with theeventand called withgetBeanManager().For
bus, it is only used to get certain properties of certain class name.For all these three fields, the two tests inside the
ClassUnwrapperTestare not trying to modify them but just accessing them. Repeatly creatinglifecycle,busandeventobject will increase the cost of running tests. When run on our own machine, the test runtime can jump from5.4858 sto4.5919 safter applying the changes.