Skip to content

Bump cxf.zipkin-reporter.version from 2.17.2 to 3.3.0#1692

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/maven/cxf.zipkin-reporter.version-3.3.0
Closed

Bump cxf.zipkin-reporter.version from 2.17.2 to 3.3.0#1692
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/maven/cxf.zipkin-reporter.version-3.3.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Feb 15, 2024

Bumps cxf.zipkin-reporter.version from 2.17.2 to 3.3.0.
Updates io.zipkin.reporter2:zipkin-reporter-brave from 2.17.2 to 3.3.0

Release notes

Sourced from io.zipkin.reporter2:zipkin-reporter-brave's releases.

Zipkin Reporter 3.2 deprecates Sender for a simpler type BytesMessageSender. This only supports synchronous invocation (as used by the async reporters in the reporting thread) and requires senders to pass an empty list vs a complicated and usually implemented check() function. The result is being able to implement a custom sender in less than 50 lines including imports like below! Thank a lot to @​anuraaga and @​reta for the review on this.

package brave.example;
import com.linecorp.armeria.client.WebClient;
import com.linecorp.armeria.common.AggregatedHttpResponse;
import com.linecorp.armeria.common.HttpData;
import com.linecorp.armeria.common.HttpMethod;
import com.linecorp.armeria.common.HttpRequest;
import com.linecorp.armeria.common.MediaType;
import java.io.IOException;
import java.util.List;
import zipkin2.reporter.BytesMessageEncoder;
import zipkin2.reporter.BytesMessageSender;
import zipkin2.reporter.ClosedSenderException;
import zipkin2.reporter.Encoding;
final class WebClientSender extends BytesMessageSender.Base {
final WebClient zipkinApiV2SpansClient;
volatile boolean closeCalled; // volatile as not called from the reporting thread.
WebClientSender(WebClient zipkinApiV2SpansClient) {
super(Encoding.JSON);
this.zipkinApiV2SpansClient = zipkinApiV2SpansClient;
}
@Override public int messageMaxBytes() {
return 500_000; // Use the most common HTTP default
}
@Override public void send(List<byte[]> encodedSpans) throws IOException {
if (closeCalled) throw new ClosedSenderException();
byte[] body = BytesMessageEncoder.JSON.encode(encodedSpans);
HttpRequest request =
HttpRequest.of(HttpMethod.POST, "", MediaType.JSON, HttpData.wrap(body));
AggregatedHttpResponse response = zipkinApiV2SpansClient.blocking().execute(request);
try (HttpData content = response.content()) {
if (!response.status().isSuccess()) {
if (content.isEmpty()) {
throw new IOException("response failed: " + response);
}
throw new IOException("response failed: " + content.toStringAscii());
}
}
}
@Override public void close() {
closeCalled = true;
}
</tr></table>

... (truncated)

Commits
  • 9b4489e [maven-release-plugin] prepare release 3.3.0
  • ee69d43 Renames HttpSender to BaseHttpSender (#256)
  • 9f3a99a Adds rate limited HTTP endpoint supplier and factory (#255)
  • 51bac2a Makes constant endpoint an api with implementations available (#254)
  • ec4e01c Adds HttpSender to aid proper handling of HttpEndpointSupplier (#253)
  • be50820 brave: adds PROTO3 encoding (#252)
  • bb3f5b7 Decreases switch statements and deprecates BytesMessageEncoder (#250)
  • b5fbad8 Pulls up ConstantHttpEndpointSupplier (#251)
  • 0f03cf6 Adds HttpEndpointSupplier to allow generic discovery of HTTP endpoints (#249)
  • 334499c [maven-release-plugin] prepare for next development iteration
  • Additional commits viewable in compare view

Updates io.zipkin.reporter2:zipkin-sender-urlconnection from 2.17.2 to 3.3.0

Release notes

Sourced from io.zipkin.reporter2:zipkin-sender-urlconnection's releases.

Zipkin Reporter 3.2 deprecates Sender for a simpler type BytesMessageSender. This only supports synchronous invocation (as used by the async reporters in the reporting thread) and requires senders to pass an empty list vs a complicated and usually implemented check() function. The result is being able to implement a custom sender in less than 50 lines including imports like below! Thank a lot to @​anuraaga and @​reta for the review on this.

package brave.example;
import com.linecorp.armeria.client.WebClient;
import com.linecorp.armeria.common.AggregatedHttpResponse;
import com.linecorp.armeria.common.HttpData;
import com.linecorp.armeria.common.HttpMethod;
import com.linecorp.armeria.common.HttpRequest;
import com.linecorp.armeria.common.MediaType;
import java.io.IOException;
import java.util.List;
import zipkin2.reporter.BytesMessageEncoder;
import zipkin2.reporter.BytesMessageSender;
import zipkin2.reporter.ClosedSenderException;
import zipkin2.reporter.Encoding;
final class WebClientSender extends BytesMessageSender.Base {
final WebClient zipkinApiV2SpansClient;
volatile boolean closeCalled; // volatile as not called from the reporting thread.
WebClientSender(WebClient zipkinApiV2SpansClient) {
super(Encoding.JSON);
this.zipkinApiV2SpansClient = zipkinApiV2SpansClient;
}
@Override public int messageMaxBytes() {
return 500_000; // Use the most common HTTP default
}
@Override public void send(List<byte[]> encodedSpans) throws IOException {
if (closeCalled) throw new ClosedSenderException();
byte[] body = BytesMessageEncoder.JSON.encode(encodedSpans);
HttpRequest request =
HttpRequest.of(HttpMethod.POST, "", MediaType.JSON, HttpData.wrap(body));
AggregatedHttpResponse response = zipkinApiV2SpansClient.blocking().execute(request);
try (HttpData content = response.content()) {
if (!response.status().isSuccess()) {
if (content.isEmpty()) {
throw new IOException("response failed: " + response);
}
throw new IOException("response failed: " + content.toStringAscii());
}
}
}
@Override public void close() {
closeCalled = true;
}
</tr></table>

... (truncated)

Commits
  • 9b4489e [maven-release-plugin] prepare release 3.3.0
  • ee69d43 Renames HttpSender to BaseHttpSender (#256)
  • 9f3a99a Adds rate limited HTTP endpoint supplier and factory (#255)
  • 51bac2a Makes constant endpoint an api with implementations available (#254)
  • ec4e01c Adds HttpSender to aid proper handling of HttpEndpointSupplier (#253)
  • be50820 brave: adds PROTO3 encoding (#252)
  • bb3f5b7 Decreases switch statements and deprecates BytesMessageEncoder (#250)
  • b5fbad8 Pulls up ConstantHttpEndpointSupplier (#251)
  • 0f03cf6 Adds HttpEndpointSupplier to allow generic discovery of HTTP endpoints (#249)
  • 334499c [maven-release-plugin] prepare for next development iteration
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `cxf.zipkin-reporter.version` from 2.17.2 to 3.3.0.

Updates `io.zipkin.reporter2:zipkin-reporter-brave` from 2.17.2 to 3.3.0
- [Release notes](https://github.com/openzipkin/zipkin-reporter-java/releases)
- [Changelog](https://github.com/openzipkin/zipkin-reporter-java/blob/master/RELEASE.md)
- [Commits](openzipkin/zipkin-reporter-java@2.17.2...3.3.0)

Updates `io.zipkin.reporter2:zipkin-sender-urlconnection` from 2.17.2 to 3.3.0
- [Release notes](https://github.com/openzipkin/zipkin-reporter-java/releases)
- [Changelog](https://github.com/openzipkin/zipkin-reporter-java/blob/master/RELEASE.md)
- [Commits](openzipkin/zipkin-reporter-java@2.17.2...3.3.0)

---
updated-dependencies:
- dependency-name: io.zipkin.reporter2:zipkin-reporter-brave
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: io.zipkin.reporter2:zipkin-sender-urlconnection
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 15, 2024
@reta
Copy link
Copy Markdown
Member

reta commented Feb 15, 2024

Will be covered by https://issues.apache.org/jira/browse/CXF-8969

@reta reta closed this Feb 15, 2024
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Feb 15, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/maven/cxf.zipkin-reporter.version-3.3.0 branch February 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant