[CXF-9062]Be able to create AsyncHTTPConduit based on URLConnectionHT…

[ffang]

…TPConduit

[reta]

@ffang looks good, thank you. It would be great to have tests that use conduit with forceURLConnectionConduit property set (I believe the default is false and none of the tests actually verify this conduit works).

[ffang]

@ffang looks good, thank you. It would be great to have tests that use conduit with forceURLConnectionConduit property set (I believe the default is false and none of the tests actually verify this conduit works).

Hi @reta ,

This is a good question, actually I have run all tests with forceURLConnectionConduit set as true. And that's why I changed DigestAuthTest.java and AbstractApacheClientServerHttp2Test.java. With that change, they pass with both forceURLConnectionConduit as true or false.

Cheers
Freeman

[reta]

This is a good question, actually I have run all tests with forceURLConnectionConduit set as true.

Thanks @ffang , I suspect you have done it ad-hoc / manually, right? What we should be able to do is something like that:

<build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <executions>
                    <execution>
                        <id>forceURLConnection-test</id>
                        <goals>
                            <goal>test</goal>
                        </goals>
                        <configuration>
                            <systemPropertyVariables>
                                <org.apache.cxf.transport.http.forceURLConnection>true</org.apache.cxf.transport.http.forceURLConnection>
                            </systemPropertyVariables>
                        </configuration>
                    </execution>
                    <execution>
                        <id>default-test</id>
                        <configuration>
                            <systemPropertyVariables>
                                <org.apache.cxf.transport.http.forceURLConnection>false</org.apache.cxf.transport.http.forceURLConnection>
                            </systemPropertyVariables>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>

Basically, for modules in question (xxx-hc, xxx-hc5) we would have 2 test runs, w/o system property set (I am happy to help with that as well). Thanks!

[ffang]

This is a good question, actually I have run all tests with forceURLConnectionConduit set as true.

Thanks @ffang , I suspect you have done it ad-hoc / manually, right? What we should be able to do is something like that:

That's right, I did it manually.

<build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <executions>
                    <execution>
                        <id>forceURLConnection-test</id>
                        <goals>
                            <goal>test</goal>
                        </goals>
                        <configuration>
                            <systemPropertyVariables>
                                <org.apache.cxf.transport.http.forceURLConnection>true</org.apache.cxf.transport.http.forceURLConnection>
                            </systemPropertyVariables>
                        </configuration>
                    </execution>
                    <execution>
                        <id>default-test</id>
                        <configuration>
                            <systemPropertyVariables>
                                <org.apache.cxf.transport.http.forceURLConnection>false</org.apache.cxf.transport.http.forceURLConnection>
                            </systemPropertyVariables>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>

Basically, for modules in question (xxx-hc, xxx-hc5) we would have 2 test runs, w/o system property set (I am happy to help with that as well). Thanks!

Thanks for any help you provide. I'm gonna merge this PR for now.

Cheers
Freeman