Skip to content

misleading message when class not found#276

Closed
rosiecki wants to merge 2 commits intoapache:masterfrom
rosiecki:patch-1
Closed

misleading message when class not found#276
rosiecki wants to merge 2 commits intoapache:masterfrom
rosiecki:patch-1

Conversation

@rosiecki
Copy link
Contributor

@rosiecki rosiecki commented Jun 3, 2017

No description provided.

@deki
Copy link
Contributor

deki commented Jun 7, 2017

Thanks for the pull request.
What is shown before and after the patch?

@rosiecki
Copy link
Contributor Author

rosiecki commented Jun 7, 2017

I'm assuming we have a webservice:

package xxx.yyy.zzz;
@WebService(endpointInterface="xxx.yyy.zzz.WsEndpointInterface")
public class WsImpl {
}
  • Message before patch: "Unable to load the class xxx.yyy.zzz.WsImpl"
  • Message after patch: "Unable to load the class xxx.yyy.zzz.WsEndpointInterface"

deki
deki requested changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@deki deki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently your branch doesn't compile.

rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/ServiceImpl.java Outdated
} catch (ClassNotFoundException e) {
Message msg = new Message("COULD_NOT_LOAD_CLASS", BUNDLE,
seiClass.getCanonicalName());
Message msg = new Message("COULD_NOT_LOAD_CLASS", BUNDLE, api);
Copy link
Contributor

@deki deki Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be epi and not api

Copy link
Contributor Author

@rosiecki rosiecki Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

@asfgit asfgit closed this in 8b5ad00 Jun 21, 2017
@deki
Copy link
Contributor

deki commented Jun 21, 2017

I've applied your changes. Thank you!

asfgit pushed a commit that referenced this pull request Jun 21, 2017
@rosiecki @deki
misleading message when class not found This closes #276
29b4890
asfgit pushed a commit that referenced this pull request Jun 21, 2017
@rosiecki @deki
misleading message when class not found This closes #276
7d33e71
andymc12 pushed a commit to andymc12/cxf that referenced this pull request Oct 25, 2017
@rosiecki @andymc12
misleading message when class not found This closes apache#276
01583cc
rnetuka pushed a commit to rnetuka/cxf that referenced this pull request Oct 3, 2022
@grgrzybek
Merge pull request apache#276 from jboss-fuse/ENTESB-14188-sb1
a642c98 
[ENTESB-14188] Upgrade to Artemis 2.13.0.redhat-00006 from A-MQ 7.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deki deki deki requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rosiecki @deki