Rename misleading parameter names in MaskSensitiveHelper#2942
Merged
reta merged 1 commit intoapache:mainfrom Mar 10, 2026
Merged
Rename misleading parameter names in MaskSensitiveHelper#2942reta merged 1 commit intoapache:mainfrom
reta merged 1 commit intoapache:mainfrom
Conversation
Rename parameters like 'inSensitiveElementNames' to 'sensitiveElementNames' to avoid confusion with 'insensitive'. Also fixes typo 'inSensitiveAttirbuteNames' (missing 'b'). Closes apache#2260
reta
approved these changes
Mar 10, 2026
Member
|
Thanks @gnodet , I suspect the naming was driven by PMD or/and checkstyle complains at the time |
reta
pushed a commit
that referenced
this pull request
Mar 10, 2026
Rename parameters like 'inSensitiveElementNames' to 'sensitiveElementNames' to avoid confusion with 'insensitive'. Also fixes typo 'inSensitiveAttirbuteNames' (missing 'b'). Closes #2260 (cherry picked from commit b3d0fed) # Conflicts: # rt/features/logging/src/main/java/org/apache/cxf/ext/logging/MaskSensitiveHelper.java
reta
pushed a commit
that referenced
this pull request
Mar 11, 2026
Rename parameters like 'inSensitiveElementNames' to 'sensitiveElementNames' to avoid confusion with 'insensitive'. Also fixes typo 'inSensitiveAttirbuteNames' (missing 'b'). Closes #2260 (cherry picked from commit b3d0fed) # Conflicts: # rt/features/logging/src/main/java/org/apache/cxf/ext/logging/MaskSensitiveHelper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inSensitiveElementNames→sensitiveElementNamesto avoid confusion with "insensitive"inSensitiveAttributeNames→sensitiveAttributeNames(same issue)inSensitiveAttirbuteNames→sensitiveAttributeNamesSupersedes #2260 which had merge conflicts due to file changes since it was opened.
Closes #2260