Use LinkedHashMap for deterministic WSDL namespace prefix assignment#2944
Merged
gnodet merged 2 commits intoapache:mainfrom Mar 11, 2026
Merged
Conversation
ServiceWSDLBuilder uses a HashMap for the ns2prefix map, which causes non-deterministic namespace prefix assignment in generated WSDL. This leads to inconsistent output where elements may appear with or without namespace prefixes (e.g., <service> vs <wsdl:service>) depending on HashMap iteration order. Switch to LinkedHashMap to ensure insertion-order iteration, making the prefix assignment in getNewPrefix() deterministic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 11, 2026
Closed
reta
approved these changes
Mar 11, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
reta
pushed a commit
that referenced
this pull request
Mar 11, 2026
…2944) ServiceWSDLBuilder uses a HashMap for the ns2prefix map, which causes non-deterministic namespace prefix assignment in generated WSDL. This leads to inconsistent output where elements may appear with or without namespace prefixes (e.g., <service> vs <wsdl:service>) depending on HashMap iteration order. Switch to LinkedHashMap to ensure insertion-order iteration, making the prefix assignment in getNewPrefix() deterministic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit fa4bdfb)
reta
pushed a commit
that referenced
this pull request
Mar 11, 2026
…2944) ServiceWSDLBuilder uses a HashMap for the ns2prefix map, which causes non-deterministic namespace prefix assignment in generated WSDL. This leads to inconsistent output where elements may appear with or without namespace prefixes (e.g., <service> vs <wsdl:service>) depending on HashMap iteration order. Switch to LinkedHashMap to ensure insertion-order iteration, making the prefix assignment in getNewPrefix() deterministic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit fa4bdfb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServiceWSDLBuilderuses aHashMapforns2prefix, causing non-deterministic namespace prefix assignment in generated WSDL<service>vs<wsdl:service>) depending onHashMapiteration orderLinkedHashMapto ensure insertion-order iteration, making prefix assignment deterministicRelated: #1517 (flaky
NettyServerTest.testGetWsdlcaused by this non-determinism)Test plan
rt/wsdlmodule tests pass🤖 Generated with Claude Code