Prevent NPE thrown in getAuthorizationPolicyFromMessage for authorization header values with lenght less than 4#295
Closed
emswbandara wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…tion header values with lenght less than 4
asfgit
pushed a commit
that referenced
this pull request
Jul 20, 2017
…tion header values with length less than 4, patch from emswbandara applied, This closes #295
asfgit
pushed a commit
that referenced
this pull request
Jul 20, 2017
…tion header values with length less than 4, patch from emswbandara applied, This closes #295
andymc12
pushed a commit
to andymc12/cxf
that referenced
this pull request
Oct 25, 2017
…tion header values with length less than 4, patch from emswbandara applied, This closes apache#295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue.
In the getAuthorizationPolicyFromMessage() method in AbstractHTTPDestination class, the following line of code returns null when we provide an encoded string with character length less than 4(invalid base64 data) as the value for basic authorization headers.
eg: curl -k -d "grant_type=password&username=Username&password=Password" -H "Authorization : Basic som" http://localhost:8280/token
byte[] authBytes = Base64Utility.decode(authEncoded) (line 175)
Since this is obtained as null the following line of code throws the NPE.
String authDecoded = decodeBasicAuthWithIso8859 ? new String(authBytes, StandardCharsets.ISO_8859_1) : new String(authBytes)