Fix FormUtils.isFormPostRequest to handle content-type with parameters#2968
Open
Fix FormUtils.isFormPostRequest to handle content-type with parameters#2968
Conversation
Use startsWith instead of equals to match the content type, so that requests with parameters like "application/x-www-form-urlencoded; charset=UTF-8" (sent by jQuery $.ajax by default) are correctly recognized as form POST requests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormUtils.isFormPostRequest()usesequals()to match the content type, but in practice theContent-Typeheader can include parameters likeapplication/x-www-form-urlencoded; charset=UTF-8.This is extremely common — jQuery's
$.ajax()sends exactly this content type by default. With the current code, form POST data is silently not recognized for these requests.The fix uses
startsWithinstead ofequals, consistent with howFormEncodingProvideralready handles content types with charset parameters (seeFormEncodingProviderTestlines 264 and 283).Split out from #2955 per review feedback.
Test plan
rt/frontend/jaxrsmodule compiles and tests pass🤖 Generated with Claude Code