Skip to content

CXF-7371: use objectweb-asm to extract parameter-names from the debug-info of the service-class#300

Closed
bbodnar wants to merge 3 commits intoapache:masterfrom
bbodnar:master
Closed

CXF-7371: use objectweb-asm to extract parameter-names from the debug-info of the service-class#300
bbodnar wants to merge 3 commits intoapache:masterfrom
bbodnar:master

Conversation

@bbodnar
Copy link
Contributor

@bbodnar bbodnar commented Jul 30, 2017

@dkulp
Copy link
Member

dkulp commented Jul 31, 2017

This creates a hard dependency on a particular ASM implementation and as such is not something we will merge. You will likely need to update the org.apache.cxf.common.util.ASMHelper class to support the ClassReader (in addition to the current ClassWriter stuff) and make sure all the asm calls go through there.

@bbodnar
Copy link
Contributor Author

bbodnar commented Jul 31, 2017

OK, I will do so.

bbodnar added 2 commits August 6, 2017 22:20
…he debug-info of the service-class" (direct coding against ASM-classes undesired)

This reverts commit 914fc30.
@bbodnar
Copy link
Contributor Author

bbodnar commented Aug 6, 2017

There is no good solution for reading classes with ASM without direct coding against concrete ASM-classes (the "normal" (visitor-based) way isn't usable with reflection/proxying, because the visitors are in ASM >v3 classes (no longer interfaces); the non-visitor-based ways (tree, SAX-events) require optional ASM-libraries, whose existence must here surely not be assumed).
I see under this circumstances the only reasonable solution to extend the current (self-made) byte-code-parser to handle the Java8-constants.

@asfgit asfgit closed this in 25c6539 Aug 17, 2017
asfgit pushed a commit that referenced this pull request Aug 17, 2017
andymc12 pushed a commit to andymc12/cxf that referenced this pull request Oct 25, 2017
rmannibucau pushed a commit to rmannibucau/cxf that referenced this pull request Sep 23, 2018
rmannibucau pushed a commit to rmannibucau/cxf that referenced this pull request Mar 18, 2019
rmannibucau pushed a commit to rmannibucau/cxf that referenced this pull request May 31, 2019
rnetuka pushed a commit to rnetuka/cxf that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants