escape raw quotes after an escaped backslash in escapeJson#3167
Merged
Conversation
coheigea
approved these changes
Jun 2, 2026
coheigea
pushed a commit
that referenced
this pull request
Jun 3, 2026
(cherry picked from commit fd8674c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while fuzzing toJson/fromJson round-trips. escapeJson looked only at the single char before a " or \ to decide it was already escaped, so a value holding a complete escaped-backslash pair (\) followed by a quote left that quote raw and broke out of its JSON string, letting a string value inject sibling members. Consume a backslash together with the char it escapes in one pass, so any leftover raw quote or backslash is always escaped while existing sequences are kept. Same single-char-lookback flaw as the reader fix in #3140.