Skip to content

CXF-7643 ensure CDI extension defaults are CDI compliant#393

Merged
dkulp merged 2 commits intoapache:masterfrom
rmannibucau:fix/CXF-7643_ensure-defaults-for-cdi-extension-are-spec-compliant
Mar 21, 2018
Merged

CXF-7643 ensure CDI extension defaults are CDI compliant#393
dkulp merged 2 commits intoapache:masterfrom
rmannibucau:fix/CXF-7643_ensure-defaults-for-cdi-extension-are-spec-compliant

Conversation

@rmannibucau
Copy link
Contributor

This PR tries to make defaults of the CDI extension better, here are the changes:

  1. if it detects OWB-web or weld-web it deactivate default context beans for HttpServletRequest and ServletContext
  2. it observes beans to detect the types conflicting with "auto" context beans
  3. it fires the extension and exposes the list of exclusion to let integration layers configure it properly if 1/2 defaults are not enough
  4. when it adds context beans it removes @default from the ones which are found with 1/2/3 - but it keeps it with the cxf specific qualifier if needed (best practise being to use this classifier for internal/extensions needs)

…+ add a way for cdi container to integrate with cdi to configure it
@johnament
Copy link
Contributor

Can you update one of the existing systests to confirm that the various injection points are available, with the needed dependencies on the classpath?

@rmannibucau
Copy link
Contributor Author

@johnament done

@dkulp dkulp merged commit effefb0 into apache:master Mar 21, 2018
@rmannibucau rmannibucau deleted the fix/CXF-7643_ensure-defaults-for-cdi-extension-are-spec-compliant branch March 21, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants