NPE when annotations bundle found but not active #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundle.getBundleContext() will give an NPE (in Equinox) if the bundle can be found but is not active. Would also be good to at least log the exception in debug mode to point to a possible problem.
| return null; | ||
| } | ||
| if (bundle.getState() != Bundle.ACTIVE) { | ||
| bundle.start(); |
There was a problem hiding this comment.
is it me or the indentation is mixed, space and tabs?
Contributor
Author
There was a problem hiding this comment.
Uh.... sorry, fixed. Was lazy and didn't edit it in the IDE but directly in GitHub and thought GitHub would be smart and tell me if indent uses the wrong characters. It doesn't.
Fixed indent
Contributor
|
Looks good thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle.getBundleContext() will give an NPE (in Equinox) if the bundle can be found but is not active.
Would also be good to at least log the exception in debug mode to point to a possible problem.