Conversation
fa93f25 to
5463c82
Compare
|
@coheigea any thoughts on this one? |
coheigea
left a comment
There was a problem hiding this comment.
When I tried the CreateDigestInterceptor in a test, it writes the header out correctly, but the message body is blank. Here is a test to reproduce:
I suggest looking at the JOSE interceptors to see how they do it: https://github.com/apache/cxf/tree/master/rt/rs/security/jose-parent/jose-jaxrs/src/main/java/org/apache/cxf/rs/security/jose/jaxrs
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
93b5c67 to
47ee9bd
Compare
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
6499c07 to
80c949f
Compare
|
@coheigea I had missed calling proceed() which is added now and the test passes (although there is not a matching server-side filter configured in the test as far as I could see?) - maybe it should be a round-trip test with digest+signing+signature-validation on the client side + digestVerification+signatureCheck+signatureOfResponse serverside. I have an alternative implementation which looks more similar to the jws stuff and wraps the output stream in a cachedOutputStream if you are interested in taking a look? I could add it as a separate PR? |
|
@davidkarlsen - I'll take care of adding the tests. The latest code is still not working, if you look at SignatureHeaderUtils.createDigestHeader, the messageBody String is actually blank. Maybe use the JWS approach instead in this PR? |
20ec789 to
92c5a87
Compare
Signed-off-by: David J. M. Karlsen david@davidkarlsen.com
@coheigea