CXF-8149 - Reduce synchronization in AbstractJXBProvider #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version did what I would consider a lot of gratuitous synchronization which can be reduced in a number of ways. First, use ConcurrentHashMap instead of straight HashMap for managing for tracking the contexts created for classes and packages. At that point, we only need to do serialization when the collections don't already contain a context for the class or package. Second, move to a "ConcurrentHashSet" for collectionContextClasses. Underlying this is a ConcurrentHashMap and is used by ConcurrentHashMap as the KeySet, so we can create one of these for the collectionContextClasses. At that point, can again reduce synchronizations required. These changes were made locally at my company to address these synchronizations substantially slowing down some of our web services, and reducing synchronizations substantially improved throughput by - in most cases - reducing synchronizations and letting threads not block each other.
Author
|
nevermind, additional testing showed that ConcurrentHashMap causes more blocks than what I had done originally, I still think there's too many synchronizations occurring but need to revisit my solution |
ppalaga
pushed a commit
to ppalaga/cxf
that referenced
this pull request
Nov 12, 2024
[CSB-4978]remove cxf-http-jetty transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version did what I would consider a lot of gratuitous synchronization which can be reduced in a number of ways.
First, use ConcurrentHashMap instead of straight HashMap for managing for tracking the contexts created for classes and packages. At that point, we only need to do serialization when the collections don't already contain a context for the class or package.
Second, move to a "ConcurrentHashSet" for collectionContextClasses. Underlying this is a ConcurrentHashMap and is used by ConcurrentHashMap as the KeySet, so we can create one of these for the collectionContextClasses. At that point, can again reduce synchronizations required.
These changes were made locally at my company to address these synchronizations substantially slowing down some of our web services, and reducing synchronizations substantially improved throughput by - in most cases - reducing synchronizations and letting threads not block each other.