[CXF-8353] MediaType validation#707
Merged
andymc12 merged 2 commits intoapache:masterfrom Oct 12, 2020
Merged
Conversation
reta
reviewed
Oct 12, 2020
| // Determines whether the type or subtype contains any of the tspecials characters defined at: | ||
| // https://tools.ietf.org/html/rfc2045#section-5.1 | ||
| private static boolean isValid(String str) { | ||
| final int len = str.length(); |
Member
There was a problem hiding this comment.
Minor, may be check str.trim().length(), it seems weird media types like application/ are still passing through.
Contributor
Author
There was a problem hiding this comment.
@reta - sounds good. Since we end up trimming both type and subType at lines 114 and 115, I moved those trims to before the isValid method is called (to lines 88 and 89). Let me know if you'd prefer the trim to be in isValid instead. Otherwise, I'll plan to merge this later today. Thanks for the review!
reta
approved these changes
Oct 12, 2020
Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>
Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>
andymc12
force-pushed
the
invalidMediaTypeCheck
branch
from
e1280ff to
e0c1b36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performs validation on the type and subtype of the MediaType string passed-in according to https://tools.ietf.org/html/rfc2045#section-5.1