Fix typos "doesnt" -> "doesn't".#740
Merged
coheigea merged 1 commit intoapache:masterfrom Feb 23, 2021
Merged
Conversation
garydgregory
changed the title
andymc12
reviewed
Jan 20, 2021
Contributor
andymc12
left a comment
andymc12
left a comment
There was a problem hiding this comment.
I'd suggest "does not" at least for the logged warning. That said, I know in other open source products, they recommend not changing warning and error messages so that user scripts that might be scanning for those particular log messages won't be broken. I'm not sure what the log message migration policy is for CXF, so I'll defer to someone who has more experience with the product. But otherwise, the changes look good to me. Thanks for improving the readability of the code!
tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToCorbaHelper.java
Show resolved
Hide resolved
coheigea
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.