Unclosed input streams needs to be closed across different classes using Java language feature #747
Closed
alanmehio wants to merge 4 commits intoapache:masterfrom
Closed
Unclosed input streams needs to be closed across different classes using Java language feature #747alanmehio wants to merge 4 commits intoapache:masterfrom
alanmehio wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Will close this. I will first start to send the improvement in a newly created JIRA as a starting point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be good to use java language feature "try with resources" to close the input streams across different java classes.
The main purpose for doing so is to prevent possible memory leak. This pull request is triggered from the fix for
core/src/main/java/org/apache/cxf/resource/URIResolver.java