CXF-8532: @Priority support for ParamConverterProvider#807
Merged
reta merged 1 commit intoapache:masterfrom Jun 1, 2021
Merged
CXF-8532: @Priority support for ParamConverterProvider#807reta merged 1 commit intoapache:masterfrom
reta merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@andymc12 mind please taking a look? Also, I've noticed |
Contributor
|
Hi @reta - I'm on holiday today and tomorrow, but I'll take a look when I
get back. IIRC, MP Rest Client should take `@Priority` into account, but
maybe it isn't tested in the TCK (or maybe we've just been passing so far
by luck?). Thanks for catching this!
…On Sun, May 30, 2021 at 12:19 PM Andriy Redko ***@***.***> wrote:
@andymc12 <https://github.com/andymc12> mind please taking a look? Also,
I've noticed MicroProfileClientProviderFactory::createComparator does not
take @priority into account for providers, it is not required by spec?
(sorry didn't have time to check it myself).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#807 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFDAEMY5N7TPKBQ6B5VM2TDTQJXQZANCNFSM45ZPKWDA>
.
|
Member
Author
|
@andymc12 my apologies, double-checked the implementation, the |
Member
Author
|
Thanks a mill, @andymc12 ! |
reta
added a commit
that referenced
this pull request
Jun 1, 2021
reta
added a commit
that referenced
this pull request
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Prioritysupport forParamConverterProviderproviders