CXF-8642: ResponseImpl#hasEntity return 'false' when entity is buffered but entity stream is fully consumed with processing exception #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
commented
Jan 19, 2022
| Object actualEntity = getActualEntity(); | ||
| if (actualEntity == null) { | ||
| return false; | ||
| } else if (entityBufferred) { |
Member
Author
There was a problem hiding this comment.
When exception occurs while reading entity, it could happen that:
- getActualEntity() return
entity(sincelastEntityisnull) - but the
entity'sInputStreamis fully consumed and is not empty - however, reading over fully consumed stream in this case is equivalent to reading over empty stream: nothing left to read
As such, the hasEntity return false. Adding the short circuit logic to make sure that if entity was buffered successfully, the response is considered to have an entity.
…ed but entity stream is fully consumed with processing exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseImpl#hasEntityreturns 'false' when entity is buffered but entity stream is fully consumed with processing exception.No new TCK test cases are failing: