Reworked Data Editor Heartbeat Structure#1190
Merged
stricklandrbls merged 1 commit intoapache:mainfrom Mar 4, 2025
Merged
Conversation
stricklandrbls
added
bug
stricklandrbls
requested review from
JeremyYao,
NolanMatt,
arosien,
hdalsania,
lrbarber,
rthomas320,
scholarsmate and
shanedell
stricklandrbls
force-pushed
the
dataeditor-log-fix
branch
3 times, most recently
from
5dc2b34 to
c9cfcc0
Compare
- Resolved continous logging of `getServerHeartbeat` requests - Extracted heartbeat functionality from DataEditorClient Closes apache#1021
stricklandrbls
force-pushed
the
dataeditor-log-fix
branch
from
c9cfcc0 to
c8b4b33
Compare
Collaborator
|
Tested locally following #1021 (comment). Looks good. +1 |
JeremyYao
approved these changes
Mar 3, 2025
github-project-automation
bot
moved this from In Review
to Done
in daffodil-vscode v1.4.1
Member
|
Just a reminder that we require two +1's from committers before PR's can be merged. While we definitely appreciate and encourage +1's from non-committers, and reviews/+1's are a great way to earn merit to become a committer, they do not count towards the +1's required to merge. |
Contributor
Author
|
Ahh, thanks @stevedlawrence I didn't see that he wasn't a committer or member. I just saw the +1 and saw his activity on the project and figured he was. I've been off of this project for a while and will be sure to observe additional personnel's roles during approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getServerHeartbeatrequestsCloses #1021