Skip to content

Fix issue where functionality was missing when using useExistingServer#750

Merged
arosien merged 1 commit intoapache:mainfrom
shanedell:fix-options-for-useExistingServer
Aug 9, 2023
Merged

Fix issue where functionality was missing when using useExistingServer#750
arosien merged 1 commit intoapache:mainfrom
shanedell:fix-options-for-useExistingServer

Conversation

@shanedell
Copy link
Contributor

Fix issue where functionality was missing when using useExistingServer

  • Whenever useExistingServer was set to true a bunch of code didn't get executed.
    • However, the only code that shouldn't have been executed was running the debubbger.
    • This updates fixes that so that only the debugger isn't ran and all other functionality is still available when useExistingServer is set to true.

Closes #747

- Whenever useExistingServer was set to true a bunch of code didn't get executed.
  - However, the only code that shouldn't have been executed was running the debubbger.
  - This updates fixes that so that only the debugger isn't ran and all other functionality is still available when useExistingServer is set to true.

Closes apache#747
@shanedell shanedell force-pushed the fix-options-for-useExistingServer branch from f80114b to 28579c8 Compare August 8, 2023 20:57
Copy link
Contributor

@scholarsmate scholarsmate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@stricklandrbls stricklandrbls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@arosien arosien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arosien arosien merged commit a03c7ba into apache:main Aug 9, 2023
@shanedell shanedell deleted the fix-options-for-useExistingServer branch March 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Some functionality is lost when using useExistingServer

4 participants