Launch configuration wizard mismatched label/text#992
Merged
scholarsmate merged 1 commit intoapache:mainfrom Mar 21, 2024
Merged
Launch configuration wizard mismatched label/text#992scholarsmate merged 1 commit intoapache:mainfrom
scholarsmate merged 1 commit intoapache:mainfrom
Conversation
lrbarber
requested review from
hdalsania,
nlewis05,
rthomas320,
shanedell and
stricklandrbls
Collaborator
|
This functionality works as expected in Linux platform. Infoset diff viewer functionality configuration is not necessary to remove from the Launch wizard. Recommend bringing infoset view diff setting back in launch configuration but fix the description for infoset viewer and infoeset diff viewer, This functionality does not work in windows platform and that need to be fixed. It seems like a windows pathing issue as shown below
|
shanedell
reviewed
Mar 19, 2024
lrbarber
force-pushed
the
launch-config-wizard-mismatch
branch
from
2e7ce1f to
7df0f13
Compare
Collaborator
Author
|
Pull request has been updated. |
Collaborator
|
+1 . Everything is working as expected in Windows and Linux. @shanedell Can you verify this solution in MacOS? |
shanedell
approved these changes
Mar 19, 2024
Contributor
shanedell
left a comment
shanedell
left a comment
There was a problem hiding this comment.
+1 Just fix the formatting issue and squash and this PR should be good with another green +1
- Correcting mismatch in header/description of infoset/diff viewer in launch config wizard. - Correcting error in Windows path that prevented infoset diff viewer from opening files. Closes apache#985 Closes apache#986
shanedell
force-pushed
the
launch-config-wizard-mismatch
branch
from
478de7f to
82042b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing text description of checkbox to open infoset viewer and infoset diff viewer and
correcting url parse/file problem that prevented diff viewer from finding files on Windows.
Closes #985
Closes #986