Update scallop to 5.0.0#1063
Merged
tuxji merged 1 commit intoapache:mainfrom Aug 10, 2023
Merged
Conversation
Implements new Scallop stdoutPrintln and stderrPrintln variables to output to the STDOUT and STDERR variables instead of Console.out/err. Implements new Scallop exitHandler variable to throw a new exception that contains the exit code instead of calling Sys.exit. This exception is later caught, turned into a Daffodil ExitCode enumeration value, and handle appropriately. These changes allow unit tests using --help and --version to work as expected. Previously the expect library could not see the usage output and the call to Sys.exit caused SBT to exit. Now scallop writes to the provider buffers and does no force exit, letting our CLI testing infrastructure capture those values. When not run via test, the CLI behaves the same as before.
stevedlawrence
force-pushed
the
update/scallop-5.0.0
branch
from
46455c2 to
2163c88
Compare
stevedlawrence
approved these changes
Aug 3, 2023
Member
stevedlawrence
left a comment
stevedlawrence
left a comment
There was a problem hiding this comment.
+1
- Do all automated continuous integration checks pass?
Yes - Is the update a patch, minor, or major update?
Major update, though breaking changes are only about how--helpand--versionare handled, which is an improvement and I doubt anyone relies on the old behavior. It also adds new variables that I've implemented so that we can test--helpand--versionin our CLI test infrastructure. Those options aren't that important to test, but it's good that everything is now consistent and there are no edge cases. This could also be useful for Java tools that run the CLI by callingMain.run, since bad args won't cause them to prematurely exit anymore. - Is the license still compatible with ASF License Policy?
Yes, still MIT - Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
No changes to LICENSE, no NOTICE file - Have any transitive dependencies been added or changed?
No changes to transitive dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
📦 Updates org.rogach:scallop from
4.1.0to5.0.0⚠📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: