Require that dfdlx:repType references a global simple type definition#1075
Merged
stevedlawrence merged 1 commit intoapache:mainfrom Aug 29, 2023
Merged
Conversation
Primitive types do not carry any DFDL properties and so do not make for very good repTypes. To support primitive types as a repType, all DFDL proprties would need to come from the general format, which would only make sense if a few specific cases. Instead, we simply disallow primitive repTypes, instead requiring that repType be a QName to a simple global type definition, which DFDL properties can be put. This creates a new function to create a helpful diagnostic when it is detected that a repType references a primitive type. Additionally, dfdl:prefixLengthType already has this restriction, and is modified to use this new helper function. Deprecation/Compatibility: dfdlx:repType can no longer reference primitive types (e.g. xs:int). Instead, a global simple type definition should be created with that has a base of the primitive type. DAFFODIL-2211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primitive types do not carry any DFDL properties and so do not make for very good repTypes. To support primitive types as a repType, all DFDL proprties would need to come from the general format, which would only make sense if a few specific cases.
Instead, we simply disallow primitive repTypes, instead requiring that repType be a QName to a simple global type definition, which DFDL properties can be put.
This creates a new function to create a helpful diagnostic when it is detected that a repType references a primitive type. Additionally, dfdl:prefixLengthType already has this restriction, and is modified to use this new helper function.
Deprecation/Compatibility:
dfdlx:repType can no longer reference primitive types (e.g. xs:int). Instead, a global simple type definition should be created with that has a base of the primitive type.
DAFFODIL-2211