Merged
Conversation
stevedlawrence
approved these changes
Sep 6, 2023
Member
stevedlawrence
left a comment
There was a problem hiding this comment.
+1
Note that there were no tagged releases between 1.0.4 and 1.0.7
GitHub Diff: EXIficient/exificient@exificient-1.0.4...exificient-1.0.7
Can't find updated release notes
- Do all automated continuous integration checks pass?
Yes - Is the update a patch, minor, or major update?
Patch update, mostly infrastructure/cleanup changes, plus a couple of bug fixes, one of which was fixed by Daffodil devs so errors are handled correctly - Is the license still compatible with ASF License Policy?
Yes, still MIT - Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
No changes to LICENSE, no NOTICE file - Have any transitive dependencies been added or changed?
Yes, removed jaxb-core, jaxb-impl, and jaxb-api dependencies. Also added slf4j-depdency, but Daffodil already has that. Will update license files to remove jaxb references.
Update CLI LICENSE and README files to remove JAXB references. JAXB is removed as a dependency to exificient and that was the only thing that used it.
436c5c7 to
f5967b2
Compare
tuxji
approved these changes
Sep 6, 2023
Contributor
tuxji
left a comment
There was a problem hiding this comment.
+1
I noticed the logging and jaxb changes too. So Daffodil needs fewer jars now; that's nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
📦 Updates com.siemens.ct.exi:exificient from
1.0.4to1.0.7📜 Changelog
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (1.0.4).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: