Bump SonarSource/sonarcloud-github-action from v1.9 to v2.1.1

[stevedlawrence]

This updates the docker container used to do the scan and should use the support Java 17 version.

Also uses correct capitalization of "SonarSource", maybe this is why dependabot never updated this for us?

This also enables the scan on pull requests. I'm not sure why we enabled it only when merged to main, but the documentation claims it works on PRs too, so lets do that.

DAFFODIL-2856

[stevedlawrence]

For reference, here is the diff of the github action to this current version: SonarSource/sonarcloud-github-action@v1.9.1...v2.1.1

[stevedlawrence]

My first commit allowed a scan to run on PR, since the documentation says it's possible. The documentation is correct, however, it leaves out that due to limitations in GitHub actions it will not work from PR's from a forked repo. This is because github actions does not pass secrets to workflows originating from a forked repository to prevent leaking secret. But this means the SONAR_TOKEN secret that is required cannot be passed to the scan. So until SonarCloud comes up with alternative that does not require a secret token, we cannot allow scans on PRs.

[tuxji]

+1

Thanks for noticing the camel case, that probably was why we didn't get any dependabot PRs.

[tuxji]

I suggest you approve too and merge, Steve, since this is really a version bump anyway.

[stevedlawrence]

+1