Include the crossVersion in daffodil jars packaged in tar/zip/RPM#1147
Merged
stevedlawrence merged 1 commit intoapache:mainfrom Jan 17, 2024
Merged
Conversation
tuxji
approved these changes
Jan 17, 2024
Contributor
tuxji
left a comment
tuxji
left a comment
There was a problem hiding this comment.
+1
I wonder if we should file an issue with the sbt-native-packager maintainer to replace the default mapping with our own mapping? I don't think callers would mind slightly longer jar names as long as the jar names are now consistent with ivy and maven jars.
daffodil-cli/build.sbt
Outdated
|
|
||
| // When the sbt-native-packger plugin creates a tar/zip/RPM/etc, it does not include the | ||
| // crossVersion in mapping of jars built from this project (i.e. org.apache.daffodil jars only). | ||
| // There are cases where this crossVersion would be useful (e.g. consistenncy with Ivy jar names |
Member
Author
There was a problem hiding this comment.
Will fix.
I wonder if we should file an issue with the sbt-native-packager maintainer
sbt-native-packager unfortunately seems pretty dead. PR's aren't getting merged and releases aren't being made (even though some tags have been created). I think whoever the maintainers are have lost interest/time.
The sbt-native-packager plugin does not include the crossVersion in the Daffodil jars that it packages in tar/zip/RPM/etc. This could be useful for more easily comparing jars from maven (which do include the crossVersion) or creating a local Ivy/maven repo. The plugin does not have an configuration option to set this, so this directly modifies the mappings that the plugin creates to include the crossVersion for Daffodil jars only. For example, a package mapping that was previously this: lib/org.apache.daffodil.daffodil-lib-3.7.0.jar is now changed to this: lib/org.apache.daffodil.daffodil-lib_2.12-3.7.0.jar DAFFODIL-2849
stevedlawrence
force-pushed
the
daffodil-2849-native-packager-jar-names
branch
from
e0d468c to
87f8daa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sbt-native-packager plugin does not include the crossVersion in the Daffodil jars that it packages in tar/zip/RPM/etc. This could be useful for more easily comparing jars from maven (which do include the crossVersion) or creating a local Ivy/maven repo.
The plugin does not have an configuration option to set this, so this directly modifies the mappings that the plugin creates to include the crossVersion for Daffodil jars only.
For example, a package mapping that was previously this:
is now changed to this:
DAFFODIL-2849