Add test showing optional elements cannot have predicates in expressions#1179
Merged
stevedlawrence merged 1 commit intoapache:mainfrom Mar 13, 2024
Conversation
Optional elements used to be implemented as arrays with a max size of one. A side effect of this was that accessing these elements in an expression required a predicate (e.g. /path/to/optional[1]). However, at some point we changed the implementation so optional elements were no longer arrays and were added to the infoset just like scalars. This change also meant they no longer needed, or were allowed to have, predicates in expressions. This adds a test to confirm that behavior. This also adds a colon to "subset" error messages to make the actual error message more clear. DAFFODIL-2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional elements used to be implemented as arrays with a max size of one. A side effect of this was that accessing these elements in an expression required a predicate (e.g. /path/to/optional[1]).
However, at some point we changed the implementation so optional elements were no longer arrays and were added to the infoset just like scalars. This change also meant they no longer needed, or were allowed to have, predicates in expressions. This adds a test to confirm that behavior.
This also adds a colon to "subset" error messages to make the actual error message more clear.
DAFFODIL-2013