Bump SonarSource/sonarcloud-github-action from 3.1.0 to 4.0.0#1385
Merged
olabusayoT merged 1 commit intomainfrom Jan 8, 2025
Merged
Conversation
…rce/sonarqube-scan-action Replaces [SonarSource/sonarcloud-github-action](https://github.com/sonarsource/sonarcloud-github-action) 3.1.0 with [SonarSource/sonarcloud-scan-action](https://github.com/sonarsource/sonarqube-scan-action) 4.1.0. The new action merges support for SonarSource's Cloud and On-premis offerings. The old action is deprecated in favor of this one. Signed-off-by: dependabot[bot] <support@github.com>
ffdf2e7 to
c005c87
Compare
stevedlawrence
approved these changes
Jan 3, 2025
Member
stevedlawrence
left a comment
There was a problem hiding this comment.
+1
Note that SonarSource has deprecated sonarcloud-github-action in favor of the new sonarqube-scan-action, which supports both the cloud and on-premises services. I've updated this switch to the latest version of that.
- Do all automated continuous integration checks pass?
Yes, however, the scan will not run until we merge this PR into main, We'll want to double check this update works after merging - Is the update a patch, minor, or major update?
Major, but the changes really seem related to the supporting both cloud and on-premises, functionally it seems like it should be very similar and no affect Daffodil - Is the license still compatible with ASF License Policy?
License is LGPL, which is Category-X and not compatible with ASF policy. However, we do not distribute this and it isn't required to use Daffodil, so this doesn't cause problems. - Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
Not applicable, we do not distribute - Have any transitive dependencies been added or changed?
Not applicable, we do not distribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps SonarSource/sonarcloud-github-action from 3.1.0 to 4.0.0.
Release notes
Sourced from SonarSource/sonarcloud-github-action's releases.
Commits
02ef911Shorten description and remove mend docker check4afec88SCSCANGHA-28 Rebranding48d9e10SCSCANGHA-25 Replace the Docker action by a composite action forwarding to th...982992aAdd Jira integration9f9bba2Recommend to not use this action for analysis of Dart codeYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)