Skip to content

Update icu4j to 68.2#498

Merged
stevedlawrence merged 1 commit into
apache:masterfrom
scala-steward:update/icu4j-68.2
Mar 16, 2021
Merged

Update icu4j to 68.2#498
stevedlawrence merged 1 commit into
apache:masterfrom
scala-steward:update/icu4j-68.2

Conversation

@scala-steward
Copy link
Copy Markdown
Contributor

Updates com.ibm.icu:icu4j from 67.1 to 68.2.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (67.1).
You might want to review and update them manually.

daffodil-cli/bin.LICENSE
daffodil-runtime1/src/test/scala/org/apache/daffodil/processors/input/TestICU.scala
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.ibm.icu", artifactId = "icu4j" } ]

labels: library-update, old-version-remains

@stevedlawrence
Copy link
Copy Markdown
Member

+1

  • Do all automated continuous integration checks pass?
    Yes
  • Is the update a patch, minor, or major update?
    Major release, though no API issues or changes that affect Daffodil mentioned in release notes
  • Is the license still compatible with ASF License Policy?
    Yes, same license and no changes to ASF policy
  • Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
    Yes, minor change to switch links from dead code.google.com to github.com, fixed in fixup commit
  • Have any transitive dependencies been added or changed?
    No changes to transitive dependencies

Copy link
Copy Markdown
Contributor

@tuxji tuxji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I haven't gotten to the rest of the PRs yet - they're fair game. This PR is good to squash and merge.

@stevedlawrence stevedlawrence merged commit 368f4a5 into apache:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants