Add test that reproduces Runtime SDE bug.#731
Conversation
| <sequence> | ||
| <annotation> | ||
| <appinfo source="http://www.ogf.org/dfdl/"> | ||
| <dfdl:setVariable ref="f:someVar">{ dfdl:valueLength(someElement, "bytes") } |
There was a problem hiding this comment.
If you use the value attribute for the expression does it still fail? Might be good to add a test for both syntaxes to make sure however this is resolved works for both.
There was a problem hiding this comment.
Yup. I added a test to verify this.
| </dfdl:setVariable> | ||
| </appinfo> | ||
| </annotation> | ||
| </sequence> |
There was a problem hiding this comment.
Is it worth added an inputValueCalc and/or outputValueCalc to ensure that the variable actually gets the right value? I could imagine a but where the SDE goes away but doesn't actually calculate the correct value and we wouldn't know.
There was a problem hiding this comment.
Added a subsequent assertion that the variable gets value 4.
| val runner = Runner(testDir, "setVarWIthValueLength.tdml") | ||
|
|
||
| @AfterClass def shutDown() = { | ||
| runner.reset |
There was a problem hiding this comment.
Might want to add Unit after shutDown() and call reset() since it's also a Unit function (side-effect only).
mbeckerle
force-pushed
the
daf-2629-RSDE
branch
from
44fe8f1 to
58eefe6
Compare
DAFFODIL-2629
mbeckerle
force-pushed
the
daf-2629-RSDE
branch
from
58eefe6 to
95159c0
Compare
3 participants
DAFFODIL-2629