Merged
Conversation
Dependencies.scala: Remove xmlresolver lines now redundant since Saxon-HE 11.1.1 has added missing transitive dependencies on xmlresolver and xmlresolver data jars.
2c4ca85 to
847cda2
Compare
tuxji
approved these changes
Feb 7, 2022
Contributor
tuxji
left a comment
There was a problem hiding this comment.
+1
Patch update with transitive dependencies on xmlresolver jars now specified in Saxon's pom (making our newly added xmlresolver dependencies redundant, so I've amended the PR to remove them). All files in 11.1 and 11.1.1 jars are the same except for MANIFEST.MF, signatures, function-library.sef.xml, and Version.class due to new version and build date.
- Do all automated continuous integration checks pass?
Yes - Is the update a patch, minor, or major update?
Patch update to add xmlresolver-4.1.2 transitive dependencies - Is the license still compatible with ASF License Policy?
Yes, still MPL 2.0 - Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
No - Have any transitive dependencies been added or changed?
Yes, 11.1.1 has specified its new xmlresolver transitive dependencies in its pom, so no longer need xmlresolver dependencies in project/Dependencies.scala but still will keep xmlresolver notice in daffodil-cli/bin.NOTICE for copyright purposes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates net.sf.saxon:Saxon-HE from 11.1 to 11.1.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (11.1).
You might want to review and update them manually.
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, old-version-remains, commit-count:1