Skip to content

Update yarn build command to be yarn package#815

Merged
arosien merged 1 commit intoapache:mainfrom
shanedell:update/yarn-package-cmd
Jul 21, 2022
Merged

Update yarn build command to be yarn package#815
arosien merged 1 commit intoapache:mainfrom
shanedell:update/yarn-package-cmd

Conversation

@shanedell
Copy link
Contributor

This is in correlation with apache/daffodil-vscode#232

@shanedell shanedell requested a review from stevedlawrence July 19, 2022 15:11
Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shanedell shanedell requested a review from mbeckerle July 20, 2022 17:23
@shanedell
Copy link
Contributor Author

@stevedlawrence Actually this will still need the yarn install for it to be able to compile the code and run the webpack command I will add it back in

@stevedlawrence
Copy link
Member

@stevedlawrence Actually this will still need the yarn install for it to be able to compile the code and run the webpack command I will add it back in

The current main branch of the vscode repo works fine for me:

git clean -xdf && yarn package

I don't get any webpack errors, and it looks like the vsix file was built successfully.

@shanedell
Copy link
Contributor Author

shanedell commented Jul 20, 2022

You are right I actually run yarn install in prepackage so it can be removed will do that one oversight on my part

Copy link

@arosien arosien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shanedell shanedell force-pushed the update/yarn-package-cmd branch from 0c9ade8 to 02c9cf0 Compare July 21, 2022 15:06
@shanedell shanedell removed the request for review from mbeckerle July 21, 2022 15:07
@arosien arosien merged commit 497e310 into apache:main Jul 21, 2022
@shanedell shanedell deleted the update/yarn-package-cmd branch July 21, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants