Implement a encode/decodeEXI command to the CLI#878
Implement a encode/decodeEXI command to the CLI#878jadams-tresys merged 1 commit intoapache:mainfrom
Conversation
stevedlawrence
left a comment
There was a problem hiding this comment.
+1 Looks pretty straightforward. Just some minor suggestions.
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
tuxji
left a comment
There was a problem hiding this comment.
I would like to request you make Steve's suggested changes and add additional test cases for error messages. I also would like to see #873 merged first since your changes are much smaller and the conflicts will be easier to fix & review in your pull request.
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| case Some(conf.encodeEXI) => { | ||
| val encodeOpts = conf.encodeEXI |
There was a problem hiding this comment.
I'm puzzled why we're seeing codecov check warnings that some lines are not covered by tests, when we do have a new test.
I remember Mike commented in the JIRA issue that XML and EXI files look so different that we might not even need a |
stevedlawrence
left a comment
There was a problem hiding this comment.
+1 looks good with minor suggestions and rebased to work with the latest master to get the exi factory from an EXIInfosetHandler.
daffodil-cli/src/it/scala/org/apache/daffodil/exi/TestEXIEncodeDecode.scala
Show resolved
Hide resolved
3ef4ee7 to
41d8cd4
Compare
|
All issues should be addressed, including errors that were being seen on Windows CI machines. @tuxji just need your approval as I removed the expectEOF function. |
This command simply encodes an existing XML file to EXI using Exificient. It will do a schema aware encoding if a schema is provided. On the other side the decodeEXI command will decode an existing EXI file to a plain text XML file. This is a useful feature as there isn't an easy existing way to perform these conversions using a schema aware encoding as it requires the use of the DaffodilXMLEntityResolver for anything more than a basic schema. DAFFODIL-2750
d90c12a to
d984fbc
Compare
This command simply encodes an existing XML file to EXI using Exificient. It will do a schema aware encoding if a schema is provided. On the other side the decodeEXI command will decode an existing EXI file to a plain text XML file.
This is a useful feature as there isn't an easy existing way to perform these conversions using a schema aware encoding as it requires the use of the DaffodilXMLEntityResolver for anything more than a basic schema.
DAFFODIL-2750